🐛 Properly handle XPathParser#document, Child#document # => nil#261
Closed
pboling wants to merge 2 commits intoruby:masterfrom
Closed
🐛 Properly handle XPathParser#document, Child#document # => nil#261pboling wants to merge 2 commits intoruby:masterfrom
pboling wants to merge 2 commits intoruby:masterfrom
Conversation
kou
reviewed
Jul 8, 2025
Member
kou
left a comment
There was a problem hiding this comment.
Could you split this PR to logically separated PRs?
For example:
- Refactoring by
&.(This must not change the current behavior) - Caching retrieved
doctypein a local variable (This must not change the current behavior) - Removing redundant
return(This must not change the current behavior) - Reusing
XPath.match(This must not change the current behavior) - Changing
XPath.matchbehavior - Adding support for
Elements#eachwithout document
Author
|
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XPathParser#document,Child#documentreturningnilXPath#first&XPath#eachwhenparser.parsewas returningnilparser.parsenow returns[]instead ofnilwhen it otherwise would have beennil.