Skip to content
This repository was archived by the owner on Dec 12, 2021. It is now read-only.

treat ActiveRecord::Relation as Array#917

Open
chrosciu wants to merge 5 commits intoryanb:masterfrom
neubloc:master
Open

treat ActiveRecord::Relation as Array#917
chrosciu wants to merge 5 commits intoryanb:masterfrom
neubloc:master

Conversation

@chrosciu
Copy link
Copy Markdown

This fixes the problem with Rails 4, where ActiveRecord::Relation is no longer recognized as Array, which gives problems when defining abilities with joins - see #916

@mhenrixon
Copy link
Copy Markdown

👍 merge this quickly please is cancan dead or what?

@Loremaster
Copy link
Copy Markdown

+1 for merge!

@dgilperez
Copy link
Copy Markdown

💯

@ghost
Copy link
Copy Markdown

ghost commented Aug 23, 2013

+1 Having the exact same issue after upgrading from Rails 3.2 to 4.0. Using the cancan gem version 1.6.10.

@michaldarda
Copy link
Copy Markdown

👍

@johncalvinyoung
Copy link
Copy Markdown

About time to merge. This has been a big annoyance for me.

@ghost
Copy link
Copy Markdown

ghost commented Sep 17, 2013

+1

2 similar comments
@noiseunion
Copy link
Copy Markdown

👍

@ricardodovalle
Copy link
Copy Markdown

👍

@nacengineer
Copy link
Copy Markdown

+1 and looking forward to @ryanb coming back from sabbatical

@sproot
Copy link
Copy Markdown

sproot commented Jan 27, 2014

+1

@jcoyne
Copy link
Copy Markdown

jcoyne commented Jan 28, 2014

I'm hitting this too. Please merge.

@ghost
Copy link
Copy Markdown

ghost commented Jan 28, 2014

If Railscasts.com is any indication, Ryan Bates is not actively working on projects right now. If Ryan could delegate responsibility for CanCan to someone else, that would be wonderful. If someone here could take the existing pull requests and begin to maintain this gem again, I would be grateful. Until that time, I have stopped using CanCan in any new applications or in any Rails 4 application. I have moved to Pundit.

It would appear that this gem is becoming abandonware, if it isn't already 😦

@nacengineer
Copy link
Copy Markdown

@BigNerdRanchDan @ryanb is on sabbatical due to burnout. He'll most likely be back, but it may be some time yet. Not quite abandonware yet.

@chrosciu
Copy link
Copy Markdown
Author

This change has been included in cancan successor: https://github.com/bryanrite/cancancan.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.