This repository was archived by the owner on Dec 12, 2021. It is now read-only.
Clear up inconsistency in authorize_resource examples#924
Open
kyletolle wants to merge 1 commit intoryanb:masterfrom
Open
Clear up inconsistency in authorize_resource examples#924kyletolle wants to merge 1 commit intoryanb:masterfrom
kyletolle wants to merge 1 commit intoryanb:masterfrom
Conversation
Changed the explanation of the code in the example to have the same references and order as the related example code.
kyletolle
referenced
this pull request
Aug 21, 2013
…Authorization class code into ControllerResource
|
Thanks for your submission! The ryanb/cancan repository has been inactive since Sep 06, 2013. CanCan has many open issues, including missing support for Rails 4. To keep CanCan alive, an active fork exists at cancancommunity/cancancan. The new gem is cancancan. More info is available at #994. If your pull request or issue is still applicable, it would be really appreciated if you resubmit it to CanCanCan. We hope to see you on the other side! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
While reading through the source code and its examples, I noticed what I believe is an inconsistency in the example code and example explanation for
authorize_resource.I created two comments on the related lines in the commit where this was introduced. The comments are asking whether my hunch is correct.
25a1c55#L2R115
25a1c55#L2R118
This pull request is created in case my hunch proves correct, and the documentation needs to be updated to reflect that.
Change Description
Changed the explanation of the code in the example to have the same references and order as the related example code.
Previously, the example code referenced a
book, whereas the explanation of that example code mentioned ashow. The example and the explanation did not match.