Replace kerberos with spnego#199
Merged
mattp- merged 4 commits intosaltstack:developfrom Feb 6, 2020
stockholmuniversity:replace_kerberos_with_spnego
Merged
Replace kerberos with spnego#199mattp- merged 4 commits intosaltstack:developfrom stockholmuniversity:replace_kerberos_with_spnego
mattp- merged 4 commits intosaltstack:developfrom
stockholmuniversity:replace_kerberos_with_spnego
Conversation
requests-kerberos is deprecated, switch to the maintained requests-gssapi.
No idea why it was added in 5a11651
This will install requests-gssapi automatically when installing 'pepper[kerberos]'.
mattp-
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the aged and, according to one of the maintainers, deprecated and replaced (see requests/requests-kerberos#116 (comment)) requests-kerberos with requests-gssapi. They are feature compatible and requests-gssapi even feature a shim, which I decided not to use since it's marked as deprecated, so we would only have to change the import.
6127060 maybe should have been another PR but I decided to put it here. It disabled the password prompt, which is unnecessary, when using eauth=kerberos.