Make the dependency to setuptools explicit for python > 3.12#240
Closed
Pierre-Sassoulas wants to merge 1 commit intosaltstack:developfrom
Closed
Make the dependency to setuptools explicit for python > 3.12#240Pierre-Sassoulas wants to merge 1 commit intosaltstack:developfrom
Pierre-Sassoulas wants to merge 1 commit intosaltstack:developfrom
Conversation
``pkg_resources`` is imported and it's inside setuptools.
Collaborator
|
@Pierre-Sassoulas thanks for this - I'm going to close as I believe this should be resolved by #236. Please let me know if not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis imported and it's inside setuptools which breaks under python 3.12.There's an easy workaround (installing setuptools ourselves), but it would be nice to release a new version for this to be handled by pip.