docs: bugfix example and make idiomatic to express#2
Open
coolaj86 wants to merge 2 commits intosearchunify:mainfrom
Open
docs: bugfix example and make idiomatic to express#2coolaj86 wants to merge 2 commits intosearchunify:mainfrom
coolaj86 wants to merge 2 commits intosearchunify:mainfrom
Conversation
c6c49eb to
5226fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm assuming that this example is intended to be geared towards people who use express, so I made it more express-like.
app(the normal name of an express router) rather thanserverreturnwhich may be confusing to the reader (there's nothing being returned)next(err)handler rather than a one-off error handlerPreview
See the concise diff at 46a5302 (this is built in part on the prettier PR, but just the README part)
Preview at https://github.com/coolaj86/su-sdk/tree/express#execution