Skip to content

Linux About Modal #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiftkey merged 2 commits into from
Mar 30, 2020
Merged

Linux About Modal #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d3c46c
Linux About Modal
jfgordon2 Mar 30, 2020
a87d7a9
Clean Up
jfgordon2 Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions app/src/ui/about/about.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { Disposable } from 'event-kit'
import { Loading } from '../lib/loading'
import { RelativeTime } from '../relative-time'
import { assertNever } from '../../lib/fatal-error'
import { ReleaseNotesUri } from '../lib/releases'
import { ReleaseNotesUri, LinuxReleasesUri } from '../lib/releases'
import { encodePathAsUrl } from '../../lib/path'

const DesktopLogo = encodePathAsUrl(__dirname, 'static/logo-64x64@2x.png')
Expand Down Expand Up @@ -94,6 +94,17 @@ export class About extends React.Component<IAboutProps, IAboutState> {
return null
}

if (__LINUX__) {
const linuxReleaseLink = (
<LinkButton uri={LinuxReleasesUri}>View Releases</LinkButton>
)
return (
<Row>
<p className="no-padding">{linuxReleaseLink}</p>
</Row>
)
}

const updateStatus = this.state.updateState.status

switch (updateStatus) {
Expand Down Expand Up @@ -169,7 +180,12 @@ export class About extends React.Component<IAboutProps, IAboutState> {

private renderUpdateDetails() {
if (__LINUX__) {
return null
return (
<p>
Please visit the GitHub Desktop for Linux release page for
Linux-specific release notes and to download the latest version.
</p>
)
}

if (
Expand Down
1 change: 1 addition & 0 deletions app/src/ui/lib/releases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export const ReleaseNotesUri = 'https://desktop.github.com/release-notes/'
export const LinuxReleasesUri = 'https://github.com/shiftkey/desktop/releases/'