fix(aptos): range-check generic type index in proto conversion [PLEX-2890]#2016
Open
fix(aptos): range-check generic type index in proto conversion [PLEX-2890]#2016
Conversation
…2890] The proto schema defines `GenericTag.index` as `uint32` but the Go domain type stores it as `uint16`. `ConvertTypeTagFromProto` previously cast directly with `uint16(genericValue.Index)`, silently truncating any value above `math.MaxUint16` and causing a request to be interpreted as a different type parameter than the one supplied. Reject indices greater than `math.MaxUint16` at the proto-helper boundary, matching the existing check in `typeTagFromCapability` on the public Aptos View capability path.
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
Fletch153
requested review from
asoliman92,
b-gopalswami,
carte7000,
makramkd,
matYang,
ogtownsend and
winder
and removed request for
a team
product-security-plaid-production
Bot
requested review from
4of9,
engnke,
fouadkada,
george-dorin,
hendoxc,
ilija42,
kirqz23,
pkcll,
thomaska and
timweri
yashnevatia
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvertTypeTagFromProtocastgenericValue.Index(uint32) directly touint16, silently truncating values abovemath.MaxUint16and causing a request to be interpreted as a different type parameter.typeTagFromCapabilityon the public Aptos View capability path.math.MaxUint16accepted), overflow rejection, and missing generic value.Jira: PLEX-2890
Test plan
go test ./pkg/chains/aptos/...go vet ./pkg/chains/aptos/...