fix(aptos): reject nil tx entries in AccountTransactionsReply [PLEX-2889]#2017
Open
fix(aptos): reject nil tx entries in AccountTransactionsReply [PLEX-2889]#2017
Conversation
…889] ConvertTransactionFromProto(nil) returns (nil, nil), which let ConvertAccountTransactionsReplyFromProto silently produce a slice containing nil transactions. Downstream callers (capability scan, GetTransmitterTransactions) dereference these without checking, crashing if a malicious or buggy relayer sends nil entries. Reject nil protoTx with an indexed error instead.
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
📊 API Diff Results
|
Equivalent guard but reads naturally as "did the conversion produce a usable transaction" — also catches future converter changes that might return nil for non-nil input.
Fletch153
changed the title
Fletch153
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
carte7000,
chris-de-leon-cll,
tt-cll and
winder
and removed request for
a team
product-security-plaid-production
Bot
requested review from
4of9,
engnke,
fouadkada,
hendoxc,
ilija42,
kirqz23,
pkcll and
timweri
yashnevatia
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConvertTransactionFromProto(nil)returns(nil, nil), soConvertAccountTransactionsReplyFromProtosilently produced a slice containing nil transactions when a relayer reply contained nil entries.TxInfoRetriever.scanTransactions(incapabilities) dereferencestx.Datawith no nil check — a malicious or buggy relayer could panic the capability.PLEX-2889
Test plan
go test ./pkg/chains/aptos/...passes