Skip to content

Add router_state_address to Aptos Onramp#18882

Merged
jmank88 merged 15 commits intodevelopfrom
aptos-update
Feb 23, 2026
Merged

Add router_state_address to Aptos Onramp#18882
jmank88 merged 15 commits intodevelopfrom
aptos-update

Conversation

@JohnChangUK
Copy link
Copy Markdown
Contributor

@JohnChangUK JohnChangUK commented Aug 7, 2025 •
edited
Loading

Desc

Add router_state_address to Aptos Onramp. This is from the OnrampV2 change from the Aptos contracts.

@JohnChangUK JohnChangUK requested review from a team as code owners August 7, 2025 23:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 7, 2025

👋 JohnChangUK, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@JohnChangUK JohnChangUK mentioned this pull request Aug 7, 2025
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

Flakeguard Summary

Ran new or updated tests between develop and fe5990f (aptos-update).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

4 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAddAptosLanes_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 6m1.353333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/cld-team
TestAddTokenPool_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 6m24.163333333s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/cld-team
TestDeployAptosChain_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 5m43.056666666s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/cld-team
TestSetOCR3Offramp_Apply 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 6m6.71s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 8, 2025

Flakeguard Summary

Ran new or updated tests between develop and 01eeda9 (aptos-update).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

1 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestAddTokenPool_Apply 33.3333% false false true 3 1 2 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset/aptos false 8m43.61s @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/cld-team

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

cfal
cfal previously approved these changes Aug 8, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions Bot added the Stale label Feb 2, 2026
@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented Feb 6, 2026

@JohnChangUK Will this be revived? or can we close it?

@chainchad chainchad mentioned this pull request Feb 6, 2026
Merged
@github-actions github-actions Bot removed the Stale label Feb 7, 2026
@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented Feb 9, 2026

Closing to silence notifications

@jmank88 jmank88 closed this Feb 9, 2026
@JohnChangUK JohnChangUK reopened this Feb 16, 2026
@JohnChangUK
Copy link
Copy Markdown
Contributor Author

JohnChangUK commented Feb 16, 2026

Closing to silence notifications

Reopening, will execute upgrade this week

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 21, 2026

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Feb 21, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 enabled auto-merge February 23, 2026 14:49
@jmank88 jmank88 added this pull request to the merge queue Feb 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 23, 2026
@jmank88 jmank88 added this pull request to the merge queue Feb 23, 2026
Merged via the queue into develop with commit de0dfd6 Feb 23, 2026
222 of 224 checks passed
@jmank88 jmank88 deleted the aptos-update branch February 23, 2026 16:36
This was referenced Feb 23, 2026
Draft
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jmank88 jmank88 jmank88 approved these changes

@makramkd makramkd makramkd approved these changes

@FelixFan1992 FelixFan1992 FelixFan1992 approved these changes

@cfal cfal cfal left review comments

@rodrigombsoares rodrigombsoares rodrigombsoares left review comments

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

@ecPablo ecPablo Awaiting requested review from ecPablo

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@ajaskolski ajaskolski Awaiting requested review from ajaskolski

@bytesizedroll bytesizedroll Awaiting requested review from bytesizedroll

@CL-Eric CL-Eric Awaiting requested review from CL-Eric

@DimitriosNaikopoulos DimitriosNaikopoulos Awaiting requested review from DimitriosNaikopoulos

@giogam giogam Awaiting requested review from giogam

@graham-chainlink graham-chainlink Awaiting requested review from graham-chainlink

@jkongie jkongie Awaiting requested review from jkongie

@securejavier securejavier Awaiting requested review from securejavier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JohnChangUK @mchain0 @jmank88 @makramkd @cfal @FelixFan1992 @rodrigombsoares