fix(cre): support http multi headers#21043
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
chudilka1
previously approved these changes
Feb 13, 2026
chudilka1
previously approved these changes
Feb 13, 2026
|
george-dorin
approved these changes
Feb 13, 2026
MStreet3
commented
Feb 13, 2026
| for _, testCase := range httpActionSuccessTests { | ||
| if testCase.testCase == multiHeadersTestCase { | ||
| err = fake.Func("GET", testCase.endpoint, func(c *gin.Context) { | ||
| for name, values := range c.Request.Header { |
Contributor
Author
There was a problem hiding this comment.
for the multiheader case, return any headers sent with the request on the response and write multiple cookies
jinhoonbang
reviewed
Feb 13, 2026
| if !statusOK(resp1.StatusCode) { | ||
| return "", fmt.Errorf("HTTP Action multi-headers (Headers request) status: %d", resp1.StatusCode) | ||
| } | ||
| h := resp1.GetHeaders() //nolint:staticcheck |
Contributor
There was a problem hiding this comment.
should we also assert resp1.GetMultiHeaders() here?
jinhoonbang
reviewed
Feb 13, 2026
| if !statusOK(resp2.StatusCode) { | ||
| return "", fmt.Errorf("HTTP Action multi-headers (MultiHeaders request) status: %d", resp2.StatusCode) | ||
| } | ||
| mh := resp2.GetMultiHeaders() |
Contributor
There was a problem hiding this comment.
should we also assert resp2.GetHeaders() here?
jinhoonbang
approved these changes
Feb 13, 2026
justinkaseman
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the new MultiHeaders field so that HTTP action capability can send and receive multiple values per header (e.g. Set-Cookie, Via):
Requires
Supports