Skip to content

Add support to emit workflow metrics#21817

Merged
karen-stepanyan merged 10 commits intodevelopfrom
DF-23780
Apr 3, 2026
Merged

Add support to emit workflow metrics#21817
karen-stepanyan merged 10 commits intodevelopfrom
DF-23780

Conversation

@karen-stepanyan
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 1, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CCIPTokenTransfer_Sui2EVM_BurnMintTokenPool_WithAllowlist/Sender_not_in_allowlist_-_should_fail Logs ↗︎

View Full Report ↗︎Docs

Comment thread core/services/workflows/events/emit.go
Comment thread core/services/workflows/v2/capability_executor.go Outdated
Comment thread go.mod Outdated
@karen-stepanyan karen-stepanyan marked this pull request as ready for review April 3, 2026 13:42
@karen-stepanyan karen-stepanyan requested review from a team as code owners April 3, 2026 13:42
Copilot AI review requested due to automatic review settings April 3, 2026 13:42
jmank88
jmank88 previously approved these changes Apr 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM — introduces a new externally-triggerable event emission path (user metrics) and updates multiple module dependencies.

Changes:

  • Adds a new WASM host function path for emitting user workflow metrics (v2 proto events) and wires schema/entity mapping for beholder emission.
  • Introduces new EngineLimiters fields intended to govern user-metric emission.
  • Bumps chainlink-common, chainlink-protos/workflows, and fxamacker/cbor across root + deployment + test modules.

Reviewed changes

Copilot reviewed 13 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
core/services/workflows/v2/capability_executor.go Adds EmitUserMetric implementation and metric name normalization.
core/services/workflows/v2/disallowed_execution_helper.go Implements EmitUserMetric for disallowed execution phases (returns error).
core/services/workflows/v2/config.go Adds user-metric limiter fields and initializes/closes/evicts them.
core/services/workflows/events/emit.go Adds EmitUserMetric and routes WorkflowUserMetric to schema/entity in emitProtoMessage.
core/services/workflows/events/types.go Adds constants for WorkflowUserMetric and SchemaUserMetricV2.
go.mod, go.sum Updates core deps (fxamacker/cbor, chainlink-common, chainlink-protos/workflows).
deployment/go.mod, deployment/go.sum Mirrors dependency bumps for deployment module.
integration-tests/go.mod, integration-tests/go.sum Mirrors dependency bumps for integration tests.
integration-tests/load/go.mod, integration-tests/load/go.sum Mirrors dependency bumps for load tests.
system-tests/lib/go.mod, system-tests/lib/go.sum Mirrors dependency bumps for system test lib.
system-tests/tests/go.mod, system-tests/tests/go.sum Mirrors dependency bumps for system tests.
core/scripts/go.mod, core/scripts/go.sum Mirrors dependency bumps for scripts module.
.changeset/slim-eels-buzz.md Declares a minor release note for user-emitted workflow metrics.

Comment thread core/services/workflows/v2/config.go
Comment thread core/services/workflows/v2/capability_executor.go Outdated
Comment thread core/services/workflows/v2/capability_executor.go
Comment thread core/services/workflows/v2/capability_executor.go
mchain0
mchain0 previously approved these changes Apr 3, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants