Basic options contract and test file#3
Merged
PatrickAlphaC merged 4 commits intosmartcontractkit:mainfrom Apr 7, 2022
TobiasBK:Feat/options_contract
Merged
Basic options contract and test file#3PatrickAlphaC merged 4 commits intosmartcontractkit:mainfrom TobiasBK:Feat/options_contract
PatrickAlphaC merged 4 commits intosmartcontractkit:mainfrom
TobiasBK:Feat/options_contract
Conversation
Contributor
|
This is so cool!!!!! Yes, would love to see some tests and would be happy to merge. The use of the price feeds to get the conversion for the options is awesome!!! |
Contributor
Author
|
I've added deploy script. Updated contract comments and fixed some basic errors. I also wrote some initial tests. A lot more tests can be written, but I won't be able to get to it until next weekend. Hopefully this contract is interesting enough to get others to make it better. :) Let me know if you want anything changed, see any mistakes (there are probably a few), etc. |
Contributor
|
Looks good!! I'll give it a deeper dive in the coming month, we'll leave it as in progress for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic options contract that allows for covered calls and puts. The underlying is ETH and the payment is in DAI. This is a work in progress. I wanted to share what I had so far. I haven't written any test yet, will do in the next few days. Let me know what you think.