Add BinanceTestNet Configuration#30
Closed
aadorian wants to merge 7 commits intosmartcontractkit:masterfrom
aadorian:master
Closed
Add BinanceTestNet Configuration#30aadorian wants to merge 7 commits intosmartcontractkit:masterfrom aadorian:master
aadorian wants to merge 7 commits intosmartcontractkit:masterfrom
aadorian:master
Conversation
thodges-gh
requested changes
Jan 11, 2021
Comment on lines
+15
to
+16
| const mc = '0x162f637509672A6bD993D63c1a21F8d310971505' // your address | ||
| const tokenAddress = '0x761429d8887600dacE56BfA13651C018C1F0C538' //address of the deploy MyContract |
Contributor
There was a problem hiding this comment.
Having to change a deployment script's source is not user friendly. Can we make these environment variables instead that also take into consideration the deployed contract?
| */ | ||
|
|
||
| const payment = process.env.TRUFFLE_CL_BOX_PAYMENT || '1000000000000000000' | ||
| //const payment = process.env.TRUFFLE_CL_BOX_PAYMENT || '1000000000000000000' |
Contributor
There was a problem hiding this comment.
Please don't comment out code.
Contributor
|
@aadorian it looks like you resolved the comments but didn't push the fixes. Mind pushing those? |
Contributor
Author
Shure I will close this and pr ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Binance TestNet Configuration and dotenv
