updated for tests#71
Merged
thodges-gh merged 3 commits intosmartcontractkit:masterfrom Mar 23, 2021
Merged
Conversation
Contributor
PatrickAlphaC
commented
Mar 18, 2021
PatrickAlphaC
commented
- Added mocks
- Updated for v0.6.6 instead of 0.6.12 (so all are on the same version)
- Updated VRF and price feed tests so that they actually are real tests
|
@PatrickAlphaC shouldn't it all work with solc 0.6.12 ? |
Contributor
Author
|
It should, but it's nice to have everything on the same version. It can be a little touchy otherwise. |
thodges-gh
requested changes
Mar 19, 2021
Contributor
thodges-gh
left a comment
thodges-gh
left a comment
There was a problem hiding this comment.
Just some small things.
thodges-gh
requested changes
Mar 19, 2021
thodges-gh
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.