[Sofa.Simulation] Change event propagation pruning#5749
Merged
hugtalbot merged 3 commits intosofa-framework:masterfrom Nov 13, 2025
Merged
[Sofa.Simulation] Change event propagation pruning#5749hugtalbot merged 3 commits intosofa-framework:masterfrom
hugtalbot merged 3 commits intosofa-framework:masterfrom
Conversation
Currently the pruning event is done at node level. Despite this is not fundamentally wrong, this behavior sounds a bit weird to me as It imply there is no event pruning between controllers's which kind of introduce kind of implicit coupling of event management at node level. The PR remove this coupling
damienmarchal
added
the
pr: status to review
hugtalbot
added
pr: enhancement
Contributor
|
[ci-build][with-all-tests] |
bakpaul
approved these changes
Nov 12, 2025
hugtalbot
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the pruning of events is done at node level.
Despite this is not fundamentally invalid I have the impression this behavior is a bit weird as it imply there is a kind of implicit coupling of event management at node level.
The PR remove this coupling.
A PR in the python Binding will follow to make good use of this.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if