Skip to content

Condition PolySharp for only netstandard2.0#1934

Closed
jonathanpeppers wants to merge 1 commit intospectreconsole:mainfrom
jonathanpeppers:dev/peppers/PolySharp
Closed

Condition PolySharp for only netstandard2.0#1934
jonathanpeppers wants to merge 1 commit intospectreconsole:mainfrom
jonathanpeppers:dev/peppers/PolySharp

Conversation

@jonathanpeppers
Copy link
Copy Markdown

Hi, I did not file this on an issue, but the change is trivial, so I thought we could discuss here. Thanks!

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Context: dotnet/sdk#51430
Context: dotnet/source-build-assets#1447

We would like to use Spectre.Console for the dotnet CLI, and .NET has to be able to be completely built from source.

It would help us to have PolySharp only included when building for netstandard2.0, as that is the only target framework that needs the polyfills.

.NET would probably only build the latest target framework.

Thanks!

Context: dotnet/sdk#51430
Context: dotnet/source-build-assets#1447

We would like to use Spectre.Console for the `dotnet` CLI, and .NET has
to be able to be completely built from source.

It would help us to have `PolySharp` only included when building for
`netstandard2.0`, as that is the only target framework that needs the
polyfills.

.NET would probably only use the latest target framework.

Thanks!
@akoeplinger
Copy link
Copy Markdown

just saw @patriksvensson is moving Spectre.Console.Cli to a new repo in #1928 so I guess we'll need to pick that up as well once it's merged

@patriksvensson
Copy link
Copy Markdown
Contributor

Hi!

Thanks so much for taking the time to submit this PR.
I really appreciate the contribution!

Unfortunately, I haven’t had the capacity to review this in a timely manner, and since it was opened, the repository has changed significantly. Because of that, this PR is no longer in a state where it can be reviewed or merged as-is. This is not your fault, but mine, and I'm sorry about this.

I’m going to close it for now to help keep things tidy. That said, if you’re still interested in contributing, please feel free to open a new pull request that’s up to date with the current state of the repository, and I’ll be happy to take a look when I can. I'll promise I'll do better this time around.

Thanks again for your work and for your interest in the project!

@jonathanpeppers
Copy link
Copy Markdown
Author

No worries! Others may contribute in the future, as we've added Spectre.Console to .NET's "source build".

They might find things to contribute/fix here upstream.

@patriksvensson
Copy link
Copy Markdown
Contributor

@jonathanpeppers Thanks for understanding. Very nice to see that you're using it for the SDK.

I've started moving towards a 1.0 release and stabilization plan, so that's the main reason for doing these changes. Once we reach 1.0, only bug fixes and new additions will be made to that major version range.

@akoeplinger
Copy link
Copy Markdown

@patriksvensson
Copy link
Copy Markdown
Contributor

@akoeplinger Yes, same with Spectre.Console repository: https://github.com/spectreconsole/spectre.console/blob/main/src/Spectre.Console/Spectre.Console.csproj#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants