Condition PolySharp for only netstandard2.0#1934
Condition PolySharp for only netstandard2.0#1934jonathanpeppers wants to merge 1 commit intospectreconsole:mainfrom
PolySharp for only netstandard2.0#1934Conversation
Context: dotnet/sdk#51430 Context: dotnet/source-build-assets#1447 We would like to use Spectre.Console for the `dotnet` CLI, and .NET has to be able to be completely built from source. It would help us to have `PolySharp` only included when building for `netstandard2.0`, as that is the only target framework that needs the polyfills. .NET would probably only use the latest target framework. Thanks!
|
just saw @patriksvensson is moving Spectre.Console.Cli to a new repo in #1928 so I guess we'll need to pick that up as well once it's merged |
|
Hi! Thanks so much for taking the time to submit this PR. Unfortunately, I haven’t had the capacity to review this in a timely manner, and since it was opened, the repository has changed significantly. Because of that, this PR is no longer in a state where it can be reviewed or merged as-is. This is not your fault, but mine, and I'm sorry about this. I’m going to close it for now to help keep things tidy. That said, if you’re still interested in contributing, please feel free to open a new pull request that’s up to date with the current state of the repository, and I’ll be happy to take a look when I can. I'll promise I'll do better this time around. Thanks again for your work and for your interest in the project! |
|
No worries! Others may contribute in the future, as we've added Spectre.Console to .NET's "source build". They might find things to contribute/fix here upstream. |
|
@jonathanpeppers Thanks for understanding. Very nice to see that you're using it for the SDK. I've started moving towards a 1.0 release and stabilization plan, so that's the main reason for doing these changes. Once we reach 1.0, only bug fixes and new additions will be made to that major version range. |
|
looks like an equivalent change is already in https://github.com/spectreconsole/spectre.console.cli/blob/04c7c3f6e965df8c11033768b8b84ef2d3241d18/src/Spectre.Console.Cli/Spectre.Console.Cli.csproj#L32-L35 |
|
@akoeplinger Yes, same with Spectre.Console repository: https://github.com/spectreconsole/spectre.console/blob/main/src/Spectre.Console/Spectre.Console.csproj#L32 |
Hi, I did not file this on an issue, but the change is trivial, so I thought we could discuss here. Thanks!
Changes
Context: dotnet/sdk#51430
Context: dotnet/source-build-assets#1447
We would like to use Spectre.Console for the
dotnetCLI, and .NET has to be able to be completely built from source.It would help us to have
PolySharponly included when building fornetstandard2.0, as that is the only target framework that needs the polyfills..NET would probably only build the latest target framework.
Thanks!