Merged
Conversation
|
|
github-actions
bot
added
the
area/github
marckhouzam
approved these changes
Nov 22, 2022
Collaborator
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
Thanks @enrichman !
Collaborator
|
The go 1.15 test is failing with Looks like @umarcor what do you think? Since it is unrelated to the PR I will merge anyway. |
Contributor
Author
|
@marckhouzam you're welcome, thanks for the quick review! |
Contributor
|
@marckhouzam go 1.15 is EOL. I believe we can remove it from the CI. However, this repo has a very unclear criteria to deprecate golang versions. In theory, https://github.com/spf13/cobra/blob/main/CONDUCT.md#deprecation. In practice, it's arbitrary upon how do maintainers (or employers) feel. |
Closed
Collaborator
|
Let's move the discussion to #1864 |
Repository owner
locked as off-topic and limited conversation to collaborators
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo