[spiral/telemetry] Fix a bug with telemetry info not propagating into log records#1212
Merged
roxblnfk merged 2 commits intospiral:masterfrom Feb 10, 2025
Merged
[spiral/telemetry] Fix a bug with telemetry info not propagating into log records#1212roxblnfk merged 2 commits intospiral:masterfrom
roxblnfk merged 2 commits intospiral:masterfrom
Conversation
This fixes a bug where tracer is not using scoped proxy container, so the trace context is always empty. Without this fix, telemetry info were never actually added as extra to log records.
roxblnfk
approved these changes
Feb 10, 2025
Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where tracer is not using scoped proxy container, so the trace context is always empty.
Without this fix, telemetry info were never actually added as extra to log records.