Skip to content

Add interface clients support for circuit breaker#1532

Merged
OlgaMaciaszek merged 33 commits intomainfrom
add-interface-clients-support-for-circuit-breaker
Jul 24, 2025
Merged

Add interface clients support for circuit breaker#1532
OlgaMaciaszek merged 33 commits intomainfrom
add-interface-clients-support-for-circuit-breaker

Conversation

@OlgaMaciaszek
Copy link
Copy Markdown
Collaborator

@OlgaMaciaszek OlgaMaciaszek commented Jul 17, 2025 •
edited
Loading

@OlgaMaciaszek
Init draft.
053deb5 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Merge remote-tracking branch 'origin/main' into add-interface-clients…
8606c70 
…-support-for-circuit-breaker
@OlgaMaciaszek
Handle missing fallbacks. Fix configuration.
6dfd121 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Create proxy to invoke fallback method.
5c1e91f 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Handle proxy target instantiation exceptions.
12352c3 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add decorator.
1d9b8a6 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Switch to using decorator.
034aae7 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Refactor CircuitBreakerRestClientAdapterDecorator.
397ff05 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Refactor CircuitBreakerRestClientAdapterDecorator and CircuitBreakerR…
de9b5ce 
…estClientHttpServiceGroupConfigurer.

Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Handle empty or null fallbackClassName. Add tests.
4c3dac6 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Repackage. Add decorator tests.
a77fa3e 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Merge remote-tracking branch 'origin/main' into add-interface-clients…
19c065b 
…-support-for-circuit-breaker
@OlgaMaciaszek
Add more tests. Refactor.
d449a70 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Draft reactive implementation.
fc81ce7 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add tests for reactive implementation.
34d34fb 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Fix checkstyle. Adjust to changes in FW. Match fallback method by ret…
200dc59 
…urn type.

Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Fix configuration.
bd3dbaa 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Fix reactive implementation and add more tests.
6dc3bb2 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Refactor.
3223d8c 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add javadocs.
f7d0645 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add property flag to autoconfiguration.
6a290b6 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Reword javadoc.
d8d6636 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add docs.
15dfe57 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek OlgaMaciaszek marked this pull request as ready for review July 17, 2025 10:16
@OlgaMaciaszek
Allow using multiple fallback classes.
ac02fef 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Fix the logic for resolving fallback from multiple fallback classes.
1fe805b 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Add javadoc and regenerate configprops.
9dd9b1b 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Allow defining default fallback for all groups. Add more tests.
dcc8d8a 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Use String map keys. Handle default settings for all groups. Refactor…
a736cdd 
…. Add more tests. Adjust docs.

Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Init draft.
ca3ab9f 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Switch to using only annotations.
f0e2a29 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Rename annotation to @HttpServiceFallback. Update documentation.
3ff7bf0 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek OlgaMaciaszek linked an issue Jul 22, 2025 that may be closed by this pull request
Provide CircuitBreaker integration for Spring Interface Clients #1538
Closed
@OlgaMaciaszek OlgaMaciaszek self-assigned this Jul 22, 2025
ryanjbaxter
ryanjbaxter reviewed Jul 23, 2025
View reviewed changes
Comment thread docs/modules/ROOT/pages/spring-cloud-circuitbreaker.adoc
Comment thread docs/modules/ROOT/pages/spring-cloud-circuitbreaker.adoc Outdated
spencergibb
spencergibb approved these changes Jul 23, 2025
View reviewed changes
Comment thread ...in/java/org/springframework/cloud/client/circuitbreaker/httpservice/HttpServiceFallback.java Outdated
@OlgaMaciaszek
Rename @HttpServiceFallback attributes.
383c130 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek
Update docs.
6c0c3c5 
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com>
@OlgaMaciaszek OlgaMaciaszek merged commit 470a4b3 into main Jul 24, 2025
3 checks passed
@OlgaMaciaszek OlgaMaciaszek deleted the add-interface-clients-support-for-circuit-breaker branch July 25, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanjbaxter ryanjbaxter ryanjbaxter left review comments

@spencergibb spencergibb spencergibb approved these changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide CircuitBreaker integration for Spring Interface Clients

4 participants

@OlgaMaciaszek @ryanjbaxter @spencergibb @spring-cloud-issues