Skip to content

Make OAuth2AuthorizationCodeGenerator public#19145

Open
MaximeEsnol wants to merge 1 commit intospring-projects:mainfrom
MaximeEsnol:make-authorization-code-generator-public
Open

Make OAuth2AuthorizationCodeGenerator public#19145
MaximeEsnol wants to merge 1 commit intospring-projects:mainfrom
MaximeEsnol:make-authorization-code-generator-public

Conversation

@MaximeEsnol
Copy link
Copy Markdown

OAuth2AuthorizationCodeGenerator currently has package-private access. This makes it impossible to use it to manually generate an authorization code. There does not seem to be a particular reason for this class to be package-private, because other OAuth2TokenGenerator implementations, like JwtGenerator, OAuth2AccessTokenGenerator, and OAuth2RefreshTokenGenerator, are public already.

My proposed fix changes:

final class OAuth2AuthorizationCodeGenerator implements OAuth2TokenGenerator<OAuth2AuthorizationCode>

To:

public final class OAuth2AuthorizationCodeGenerator implements OAuth2TokenGenerator<OAuth2AuthorizationCode

Signed-off-by: MaximeEsnol <maxime.esnol02@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants