Catch WebClientException in reactive HaveIBeenPwned checker#19146
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Catch WebClientException in reactive HaveIBeenPwned checker#19146therepanic wants to merge 1 commit intospring-projects:mainfrom
WebClientException in reactive HaveIBeenPwned checker#19146therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
This change will ensure consistent behavior in the event of an I/O error with the non-reactive version of `HaveIBeenPwnedRestApiPasswordChecker`. Closes: spring-projectsgh-19142 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
May 3, 2026
Comment on lines
-80
to
+81
| .onErrorResume(WebClientResponseException.class, (ex) -> Flux.empty()); | ||
| .onErrorResume(WebClientException.class, (ex) -> Flux.empty()); |
Contributor
Author
There was a problem hiding this comment.
There is no test in either the reactive or non-reactive version that checks this, so I think we should either do nothing, or add two tests - one for the reactive version and one for the non-reactive version.
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will ensure consistent behavior in the event of an I/O error with the non-reactive version of
HaveIBeenPwnedRestApiPasswordChecker.Closes: gh-19142