lintFiles() to await on ESLint.outputFixes()#318
Merged
theoludwig merged 1 commit intomasterfrom Jan 15, 2023
unknown repository
Merged
lintFiles() to await on ESLint.outputFixes()#318theoludwig merged 1 commit intomasterfrom unknown repository
theoludwig merged 1 commit intomasterfrom
unknown repository
Conversation
This ensures that fixes are written before resolving. Without this, the file may be in a weird state if consumed right after calling lintFiles() (e.g. reading the files right after calling lintFiles() would return an empty string, stat would show a zero-sized file).
|
🙌 Thanks for opening this pull request! You're awesome. |
theoludwig
approved these changes
Jan 15, 2023
Contributor
theoludwig
left a comment
theoludwig
left a comment
There was a problem hiding this comment.
Thanks!
Indeed if outputFixes is an async function we should await it.
|
🎉 Congrats on getting your first pull request landed! |
Member
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that fixes are written before resolving.
Without this, the file may be in a weird state if consumed right after calling
lintFiles()(e.g. reading the files right after callinglintFiles()would return an empty string, stat would show a zero-sized file).What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added
awaittothis.eslint.ESLint.outputFixes(result)to ensure the fixed files are written beforelintFiles()returns.Under the hood,
ESLint.outputFixes()is an async function that awaits on a promisifiedfs.writeFile().Which issue (if any) does this pull request address?
None.
Is there anything you'd like reviewers to focus on?
Cross-platform testing. Issue may be OS-dependent because it deals with the filesystem. This issue happened on a Windows machine, I cannot verify on other platforms.