lowering: propagate snapshot pop success values in const folding#9817
Open
nivanovvv wants to merge 1 commit intostarkware-libs:mainfrom
Open
lowering: propagate snapshot pop success values in const folding#9817nivanovvv wants to merge 1 commit intostarkware-libs:mainfrom
nivanovvv wants to merge 1 commit intostarkware-libs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate remaining snapshot and popped value info for snapshot pop success arms, enabling follow-up snapshot pops to const-fold into known branches.
Note
Medium Risk
Touches compiler const-folding logic for
array_snapshot_pop_front/back, which could change lowering behavior if snapshot/boxed value propagation is incorrect. Scope is limited and covered by a new regression test.Overview
Const folding now propagates success-arm outputs for
array_snapshot_pop_front/array_snapshot_pop_back: it tracks the remaining snapshot as aSnapshot(Array(..))and tracks the popped element as a boxed snapshot value, enabling subsequent pops to be folded based on updated snapshot state.Adds a regression test ensuring a second
array_snapshot_pop_frontafter a successful first pop can be optimized into the knownNonebranch by recognizing the now-empty remaining snapshot.Written by Cursor Bugbot for commit ee725f8. This will update automatically on new commits. Configure here.