Fixed top level type of i64 and i128 values.#1602
Merged
Conversation
TomerStarkware
approved these changes
May 3, 2026
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on orizi).
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.511 ± 0.049 | 11.421 | 11.593 | 5.69 ± 0.04 |
cairo-native (embedded AOT) |
2.024 ± 0.012 | 2.003 | 2.039 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.113 ± 0.023 | 2.091 | 2.173 | 1.04 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
548.4 ± 8.1 | 533.1 | 559.9 | 1.00 |
cairo-native (embedded AOT) |
1680.8 ± 16.3 | 1656.9 | 1706.5 | 3.07 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1818.1 ± 12.5 | 1798.1 | 1832.0 | 3.32 ± 0.05 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.948 ± 0.020 | 4.928 | 4.981 | 2.28 ± 0.02 |
cairo-native (embedded AOT) |
2.172 ± 0.014 | 2.140 | 2.190 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.218 ± 0.017 | 2.191 | 2.250 | 1.02 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.830 ± 0.039 | 4.790 | 4.931 | 2.83 ± 0.03 |
cairo-native (embedded AOT) |
1.705 ± 0.015 | 1.675 | 1.727 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.764 ± 0.018 | 1.737 | 1.785 | 1.03 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
590.1 ± 7.5 | 580.2 | 600.9 | 1.00 |
cairo-native (embedded AOT) |
1741.8 ± 18.2 | 1705.1 | 1762.3 | 2.95 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1858.8 ± 18.1 | 1835.0 | 1883.8 | 3.15 ± 0.05 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
496.0 ± 3.4 | 490.3 | 500.9 | 1.00 |
cairo-native (embedded AOT) |
1878.2 ± 15.9 | 1849.5 | 1903.1 | 3.79 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2041.7 ± 14.9 | 2007.6 | 2054.7 | 4.12 ± 0.04 |
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix top level returning functions serialization.
Introduces Breaking Changes?
No. The main used API is just serialization of Span and Array of felt252.
Checklist
This change is