Conversation
…ods to README - keyword_search() now returns [] instead of raising when server returns UNIMPLEMENTED (older server versions without TextSearch endpoint) - Add regression test for the raising-client case - Add keyword_search, similarity_search, and structured_schema to API table in langchain-coordinode README
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughExtended the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|



Summary
keyword_search()now returns[]instead of raising when server returnsStatusCode.UNIMPLEMENTED(older CoordiNode without TextSearch endpoint)test_returns_empty_when_text_search_raiseskeyword_search,similarity_search,structured_schemato API table in README (were missing after feat(langchain): add CoordinodeGraph.keyword_search() #41)Root cause
keyword_search()checkedcallable(getattr(client, "text_search", None))— this catches the case where the method doesn't exist at all (e.g. bareLocalClient). But whentext_searchis defined but the server doesn't implement the endpoint, a gRPCUNIMPLEMENTEDerror propagates uncaught.Fix follows the same pattern as
refresh_schema(): broadexcept Exception+logger.debug(...).Closes #43