refactor(session): merge tree navigation actions into direction + interaction parameters#369
Open
jensenojs wants to merge 1 commit intosudo-tee:mainfrom
Open
refactor(session): merge tree navigation actions into direction + interaction parameters#369jensenojs wants to merge 1 commit intosudo-tee:mainfrom
jensenojs wants to merge 1 commit intosudo-tee:mainfrom
Conversation
…eraction parameters
Before | After
---------------------------------|------------------------------------------
select_parent_session | navigate_session_tree('parent')
select_child_session | navigate_session_tree('child', 'picker')
select_sibling_session | navigate_session_tree('sibling', 'picker')
— | navigate_session_tree('forward', 'direct', true)
— | navigate_session_tree('backward', 'direct', true)
New: forward/backward for flat global navigation by time.updated.
Parameters: direction, interaction (direct|picker), wrap, empty_policy.
Implementation: tree_directions config table, async session list lookup.
Contributor
Author
|
thank David Herman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three session navigation actions differ only by direction and picker behavior,
but each is a separate function. Adding forward/backward flat navigation would
make this worse.
navigate_session_tree(direction, interaction, wrap, empty_policy)replacesall three, with forward/backward for global next/prev by
time.updated.New: forward/backward for flat global navigation by time.updated.
Parameters: direction, interaction (direct|picker), wrap, empty_policy.
Implementation: tree_directions config table, async session list lookup.