fix: dont throw exceptions to users#44
Merged
bytestream merged 5 commits intomasterfrom Mar 11, 2024
Merged
Conversation
bytestream
reviewed
Mar 8, 2024
bytestream
reviewed
Mar 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 99.65% 99.66%
- Complexity 65 68 +3
=========================================
Files 15 15
Lines 290 296 +6
=========================================
+ Hits 289 295 +6
Misses 1 1 ☔ View full report in Codecov by Sentry. |
bytestream
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception is thrown it falls through to the user's exception handler. This creates an unknown from the library perspective as the response may not match what we expect or introduce unexpected behaviour. We should return an absolute response to prevent that.