Skip to content

fix(core): remove mistakenly put condition (#10212)#10730

Merged
lukaszzazulak merged 1 commit intomasterfrom
fix/10212-fix-unwanted-loader
Feb 19, 2026
Merged

fix(core): remove mistakenly put condition (#10212)#10730
lukaszzazulak merged 1 commit intomasterfrom
fix/10212-fix-unwanted-loader

Conversation

@lukaszzazulak
Copy link
Copy Markdown
Contributor

@lukaszzazulak lukaszzazulak commented Feb 19, 2026

The PR #10373 mistakenly put additional condition during refactoring which caused unwanted loader to be present

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a regression introduced in #10373 where an extra condition prevented (or otherwise interfered with) resolving an operation’s spec subtree, leading to an undesired loading state/behavior in the UI.

Changes:

  • Adjust OperationContainer.componentDidUpdate to request a resolved subtree whenever the operation is shown and the subtree is still unresolved.
  • Minor whitespace/formatting cleanup in onResetClick.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lukaszzazulak lukaszzazulak merged commit 62525f9 into master Feb 19, 2026
15 checks passed
swagger-bot pushed a commit that referenced this pull request Feb 20, 2026
## [5.31.2](v5.31.1...v5.31.2) (2026-02-20)

### Bug Fixes

* **core:** remove mistakenly put condition ([#10212](#10212)) ([#10730](#10730)) ([62525f9](62525f9))
* **deps:** update swagger-client to v3.36.2 to resolve peer dep issue ([#10734](#10734)) ([707010a](707010a))

### Performance Improvements

* reduce conversion from immutablejs to plain js objects ([#10682](#10682)) ([ae79054](ae79054))
@swagger-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

delendik-testops pushed a commit to ModiusOpenData/swagger-ui that referenced this pull request Mar 3, 2026
delendik-testops pushed a commit to ModiusOpenData/swagger-ui that referenced this pull request Mar 3, 2026
## [5.31.2](swagger-api/swagger-ui@v5.31.1...v5.31.2) (2026-02-20)

### Bug Fixes

* **core:** remove mistakenly put condition ([swagger-api#10212](swagger-api#10212)) ([swagger-api#10730](swagger-api#10730)) ([62525f9](swagger-api@62525f9))
* **deps:** update swagger-client to v3.36.2 to resolve peer dep issue ([swagger-api#10734](swagger-api#10734)) ([707010a](swagger-api@707010a))

### Performance Improvements

* reduce conversion from immutablejs to plain js objects ([swagger-api#10682](swagger-api#10682)) ([ae79054](swagger-api@ae79054))
davidanrod pushed a commit to davidanrod/swagger-ui that referenced this pull request Apr 9, 2026
davidanrod pushed a commit to davidanrod/swagger-ui that referenced this pull request Apr 9, 2026
## [5.31.2](swagger-api/swagger-ui@v5.31.1...v5.31.2) (2026-02-20)

### Bug Fixes

* **core:** remove mistakenly put condition ([swagger-api#10212](swagger-api#10212)) ([swagger-api#10730](swagger-api#10730)) ([62525f9](swagger-api@62525f9))
* **deps:** update swagger-client to v3.36.2 to resolve peer dep issue ([swagger-api#10734](swagger-api#10734)) ([707010a](swagger-api@707010a))

### Performance Improvements

* reduce conversion from immutablejs to plain js objects ([swagger-api#10682](swagger-api#10682)) ([ae79054](swagger-api@ae79054))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants