test: Add GC lifecycle test for identity-cached wrappers#731
Merged
kateinoigakukun merged 1 commit intomainfrom Apr 28, 2026
Merged
test: Add GC lifecycle test for identity-cached wrappers#731kateinoigakukun merged 1 commit intomainfrom
kateinoigakukun merged 1 commit intomainfrom
Conversation
Verify that WeakRef-based identity cache does not prevent garbage collection. Creates an identity-mode object, crosses it 5 times (filling identity cache), drops all references, triggers GC + event loop ticks, and asserts the Swift object is deallocated and deinit fires exactly once.
kateinoigakukun
approved these changes
Apr 28, 2026
matthewa26
added a commit
to matthewa26/JavaScriptKit
that referenced
this pull request
Apr 29, 2026
swiftwasm#731 added the GC lifecycle test (with new imported function entries) to main while this branch was open. Re-running the BridgeJS regen against the merged tree fills in the `accessLevel` field on the new entries that were absent at merge time.
wfltaylor
pushed a commit
to wfltaylor/JavaScriptKit
that referenced
this pull request
May 1, 2026
…ace (swiftwasm#709) (swiftwasm#727) * [BridgeJS] Synthesize typed-closure init access from declaration surface Resolves swiftwasm#709: a public `@JSClass` exposing a `JSTypedClosure<...>` parameter could not be consumed from another target because the synthesized `extension JSTypedClosure { init(...) }` was always internal, leaving downstream callers no way to construct the closure value without hand-rolling a public wrapper. Imported skeleton entries now record the source access level (`public`/`package`/`internal`); the closure-signature collector takes the maximum across every surface that references a given signature, and `ClosureCodegen` prefixes the synthesized init with the resulting modifier (internal stays bare). This matches the pattern `JSClassMacro` already uses for `init(unsafelyWrapping:)`. * [BridgeJS] Address PR feedback and refresh generated artifacts - Make `accessLevel` decode-tolerant on imported skeleton structs (`ImportedFunctionSkeleton`, `ImportedConstructorSkeleton`, `ImportedGetterSkeleton`, `ImportedSetterSkeleton`, `ImportedTypeSkeleton`) by writing explicit `init(from:)` decoders that fall back to `.internal` when the key is missing. Without this, any pre-existing skeleton JSON without the new field fails decoding — the `build-examples` CI job hit `DecodingError.keyNotFound` for `accessLevel` against externally consumed skeletons. - Extract a private `recordSignature` helper so `visitClosure` and `recordInjectedSignature` share a single merge implementation. - Assert in `withAccessLevel(rawLevel:)` so unknown access strings ("open", "private", future schema additions) surface in debug builds instead of silently inheriting the outer level. - Document the `.internal` seeding assumption on `ClosureSignatureCollectorVisitor.init(moduleName:signatures:)`. - Regenerate the BridgeJS pre-generated artifacts under Benchmarks/, Examples/PlayBridgeJS/, Tests/BridgeJSIdentityTests/, and Tests/BridgeJSRuntimeTests/ via `./Utilities/bridge-js-generate.sh`, per CONTRIBUTING.md. The runtime-tests Swift output now emits `public init` on three `JSTypedClosure` extensions whose signatures surface through public exported types. * [BridgeJS] Refresh identity tests skeleton after merge with main swiftwasm#731 added the GC lifecycle test (with new imported function entries) to main while this branch was open. Re-running the BridgeJS regen against the merged tree fills in the `accessLevel` field on the new entries that were absent at merge time. * ci: retry flaky JSPromiseTests.testPromiseAndTimer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a test verifying that the
WeakRef-based identity cache (introduced in #723) does not prevent garbage collection of Swift heap objects.The existing GC lifecycle test (
testJSWrapperIsDeallocatedAfterFinalizationinSwiftClassSupportTests) covers non-identity classes. This adds an equivalent for@JS(identityMode: true)classes where the identity cache holds aWeakRefto the wrapper.What it tests
Creates a
RetainLeakSubject(identity-mode class), crosses it to JS 5 times (filling the identity cache with aWeakRefentry), drops all Swift-side references, triggers GC + event loop ticks, and verifies:weakSubject == nil)deinitfires exactly onceThis covers the scenario where only JavaScript holds a reference to an identity-cached Swift object via
WeakRef, then that reference becomes unreachable.What changed
IdentityModeTests.swift— AddedtestIdentityCachedWrapperIsReclaimedByGCasync test. Added@JSFunction gc()import (same pattern asSwiftClassSupportTests).Generated/BridgeJS.swift+Generated/JavaScript/BridgeJS.json— Regenerated to includegcimport binding.