fix: Do not set console buffer width (ConsoleLogger)#1623
fix: Do not set console buffer width (ConsoleLogger)#1623HofmeisterAn merged 2 commits intodevelopfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe ConsoleLogger class was modified to remove problematic Windows-specific buffer width adjustment that was interfering with Microsoft Testing Platform output. The unnecessary System.Runtime.InteropServices dependency was removed, and documentation comments were updated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
It looks like setting the console buffer width can cause issues in some environments, and according to the docs, using this API is not recommended. I no longer remember why we added it. I ran a few simple tests and didn't encounter any obvious issues, so I think it's safe to remove it to avoid potential problems.
Why is it important?
-
Related issues
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.