fix: Do not enforce policies for admins#1651
Conversation
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughConfiguration updates to GitHub repository settings: CODEOWNERS ownership mappings reassigned to individual and team members, and branch protection settings modified with admin enforcement disabled for main and develop branches. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/CODEOWNERS (1)
5-7: Minor: Comment references "OSS maintainers" but owner is dotnet-team.The comment on line 5 mentions "OSS maintainers" but the actual CODEOWNERS entry on line 7 assigns ownership to
@testcontainers/dotnet-team. Consider updating the comment for consistency:📝 Suggested comment update
-# Documentation can additionally be reviewed by OSS maintainers. +# Documentation can additionally be reviewed by dotnet-team members.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/CODEOWNERS around lines 5 - 7, Update the top comment in the CODEOWNERS block so it references the actual owner group instead of "OSS maintainers": change the phrase mentioning "OSS maintainers" to reference `@testcontainers/dotnet-team` (or a neutral phrasing like "maintainers") to align the comment with the CODEOWNERS entry; look for the comment near the CODEOWNERS header and the entry that assigns /docs/ to `@testcontainers/dotnet-team` and make the wording consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/CODEOWNERS:
- Around line 5-7: Update the top comment in the CODEOWNERS block so it
references the actual owner group instead of "OSS maintainers": change the
phrase mentioning "OSS maintainers" to reference `@testcontainers/dotnet-team` (or
a neutral phrasing like "maintainers") to align the comment with the CODEOWNERS
entry; look for the comment near the CODEOWNERS header and the entry that
assigns /docs/ to `@testcontainers/dotnet-team` and make the wording consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: fbcfb800-7af0-4dca-a6d2-b34e2314a6d5
📒 Files selected for processing (2)
.github/CODEOWNERS.github/settings.yml
1 participant
What does this PR do?
With the integration of the OpenSSF Scorecard, we updated the repository settings, which resulted in admins no longer being able to approve and merge their own PRs. Due to the lack of maintainers, this is unfortunately necessary. This PR reverts the changes and does not enforce the policies for admins.
Why is it important?
-
Related issues
-
Summary by CodeRabbit