Skip to content

Upgrade asserts with teyit for Python 3.11 compatibility#319

Merged
cjwatson merged 2 commits intotesting-cabal:masterfrom
hugovk:fix-3.11
Apr 23, 2022
Merged

Upgrade asserts with teyit for Python 3.11 compatibility#319
cjwatson merged 2 commits intotesting-cabal:masterfrom
hugovk:fix-3.11

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Jan 10, 2022

Use https://github.com/isidentical/teyit to upgrade unittest asserts for better error messages.

Also assertEquals has been removed in 3.11, so use assertEqual instead.

https://docs.python.org/3.11/whatsnew/3.11.html


There are still some other things needed for 3.11 compatibility but this is a first step.

@hroncok
Copy link
Copy Markdown
Contributor

hroncok commented Jan 10, 2022

What does "teyit" mean?

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Jan 10, 2022

It's this handy tool: https://github.com/isidentical/teyit

@stephenfin
Copy link
Copy Markdown
Contributor

Can you rebase this? The branch doesn't have the Allow edits from maintainers flag set to let me do it.

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Feb 7, 2022

Hmm, strange the flag looks enabled for me:

image

Anyway, rebased!

@cjwatson cjwatson merged commit b5a7916 into testing-cabal:master Apr 23, 2022
@hugovk hugovk deleted the fix-3.11 branch April 23, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants