fix(theme): change --leading-none from 1px to unitless 1 (#1136)#1137
Open
Bsrat06 wants to merge 1 commit intothemesberg:mainfrom
Open
fix(theme): change --leading-none from 1px to unitless 1 (#1136)#1137Bsrat06 wants to merge 1 commit intothemesberg:mainfrom
Bsrat06 wants to merge 1 commit intothemesberg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1136 where
--leading-nonewas defined as1pxinstead of1.Why this is needed
Defining
line-heightas1pxcauses text overlap (as seen in the reported issue). In Tailwind CSS,leading-noneshould be unitless (1) to ensure the line height is proportional to the font size.Changes made
--leading-nonefrom1pxto1in:src/themes/themes.css(multiple occurrences)src/themes/default.csssrc/themes/enterprise.csssrc/themes/minimal.csssrc/themes/mono.csssrc/themes/playful.cssLinked Issues
Fixes #1136