Skip to content

Revert "soundwire: initial work"#1262

Closed
xiulipan wants to merge 1 commit intomasterfrom
revert-1244-soundwire
Closed

Revert "soundwire: initial work"#1262
xiulipan wants to merge 1 commit intomasterfrom
revert-1244-soundwire

Conversation

@xiulipan
Copy link
Copy Markdown
Contributor

Reverts #1244

ABI changes in this PR caused a blocking regression now. As no decision is made to update the kernel to align the ABI now.

Revert and have more discussion is a good option.

@xiulipan
Copy link
Copy Markdown
Contributor Author

@plbossart @lgirdwood @tlauda @jajanusz
Please have some decision and action about the recent blocking regression.
I think a simple revert first and discuss later is a good idea to make other feature and validation continue.

@jajanusz
Copy link
Copy Markdown
Contributor

jajanusz commented Apr 13, 2019

@xiulipan Please specify what do you mean by regression. All things look like they have no impact on driver that is not even aware of soundwire. We bumped minor version what means that there are changes indeed but it should be backward compatible.

@jajanusz jajanusz requested a review from slawblauciak April 13, 2019 18:41
@xiulipan
Copy link
Copy Markdown
Contributor Author

@jajanusz
Regression means all platform now is not able to load tplg with the dev branches
thesofproject/linux#822

Copy link
Copy Markdown
Contributor

@jajanusz jajanusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it works as designed on FW side. You just have to make driver to correctly follow ABI versioning ideology.

Copy link
Copy Markdown
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAK, this is a kernel bug. Kernel should not reject minor ABI differences (only reject major ABI differences)

@lgirdwood lgirdwood closed this Apr 15, 2019
@plbossart
Copy link
Copy Markdown
Member

NAK, this is a kernel bug. Kernel should not reject minor ABI differences (only reject major ABI differences)

It doesn't help to just close bugs and push the issues under the rug. It's not a minor change and we need a process for ABI changes. I completely disagree with just waving things through on the grounds that things are minor.

@lgirdwood
Copy link
Copy Markdown
Member

@plbossart thesofproject/linux#822 is showing only a minor ABI difference unless we are meaning another issue ?

@plbossart
Copy link
Copy Markdown
Member

@lgirdwood exactly my point, the PR 822 is showing a minor ABI difference but I don't think it is. The classification looks wrong since by adding a DAI type you can end-up with a configuration that does not work. It's different from a field that gets ignored.
And it didn't have a matching kernel PR so there is still no process to align.

@xiulipan xiulipan deleted the revert-1244-soundwire branch May 20, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants