App: Boards: Set CONFIG_COMP_DRC=y for LNL platform#8963
App: Boards: Set CONFIG_COMP_DRC=y for LNL platform#8963kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
The DRC component was not included to build. This change avoids error and DSP panic in topology load. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
lnl_enable_drc_kconfig
branch
from
79b50cd to
c4841da
Compare
singalsu
changed the title
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
| CONFIG_COMP_SRC=y | ||
|
|
||
| CONFIG_COMP_SRC_IPC4_FULL_MATRIX=y | ||
| CONFIG_COMP_DRC=y |
There was a problem hiding this comment.
Alternatively should this be a library @singalsu ?
I thought this was the direction of travel for all processing components?
There was a problem hiding this comment.
I have no idea how to do it and if it's in usable state, I saw there were problems with IIR as test. This is a fix for new platform failure #8961, so if this works I'd prefer a quick merge and improve to library later. Also better to experiment new things in mature platform like MTL.
There was a problem hiding this comment.
@plbossart we are not there yet @lyakh correct me if I'm wrong
There was a problem hiding this comment.
Didn't @lgirdwood say that we would only test volume as separate components though? Maybe I am confused on timelines, but do we agree that at some point all those processing should come as libraries?
There was a problem hiding this comment.
@plbossart you mean as loadable libraries / modules? @kv2019i is right - in principle it's all there and working, there are just a couple of "temporary minor issues," e.g. ATM it's only working with open-source toolchains like the Zephyr one, not with the Cadence Xplorer based one...
There was a problem hiding this comment.
Humm, then the stated goal of testing volume components only as libraries is not realistic until all dependencies are handled. Clearly the use of the Cadence toolchain is a key requirement, we don't release anything based on open-source toolchains.
| CONFIG_COMP_SRC=y | ||
|
|
||
| CONFIG_COMP_SRC_IPC4_FULL_MATRIX=y | ||
| CONFIG_COMP_DRC=y |
There was a problem hiding this comment.
@plbossart we are not there yet @lyakh correct me if I'm wrong
|
I'm able to test with this PR. playback tests are working fine! |
5 participants
The DRC component was not included to build. This change avoids error and DSP panic in topology load.