app: boards: Enable Probe for LNL#8982
Conversation
|
Can one of the admins verify this patch?
|
|
|
||
| CONFIG_INTEL_ADSP_IPC=y | ||
|
|
||
| CONFIG_PROBE=y |
There was a problem hiding this comment.
config PROBE
bool "Probes enabled"
default y if CAVS
Should this be CAVS | ACE so that all platforms have this by default?
config PROBE_DMA_MAX
int "Maximum injection probe DMAs attached"
The name of the Kconfig is very misleading, consider renaming to make it self-explanatory that this is for INJECTION only.
There was a problem hiding this comment.
I'm fine with these handled in separate PRs. Especially with vendor defaults, I wonder if it would be better to have some common definition files e.g. for Intel SOF platforms. The PROBE is really a generic feature not tied to hardware in anyway, so having the defaults set based on HW capabilities is a bit misleading. This is really about which feature Intel SOF builds want to have enabled.
|
|
||
| CONFIG_INTEL_ADSP_IPC=y | ||
|
|
||
| CONFIG_PROBE=y |
There was a problem hiding this comment.
OK, thank you fixed
There was a problem hiding this comment.
btw, the commit still has the typo (updating the pull request title won't change the commit).
4854181 to
ef0d267
Compare
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @gbernatxintel !
tmleman
left a comment
There was a problem hiding this comment.
For me, this is not a blocker. But please remove the 'X' from your name, the comma is also unnecessary. In my opinion, it's clearest when it's just the first and last name.
Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>Enables extraction and injection probes for LNL platform. NOTE: this commit does NOT enable probe log backend. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
ef0d267 to
e61575d
Compare
Thank you, I fixed it. |
|
Just pending on required CI to pass, otherwise ready to merge. |
|
SOFCI TEST |
Enables extraction and injection probes for LNL platform.
NOTE: this commit does NOT enable probe log backend.