waves: verify payload size and initialize memory to zero to the allocated memory in waves.c

[barry-waves]

Enhance payload corruption handling by verifying size

[lyakh]

return 0

[johnylin76]

Hi @lyakh,
at the same time I would like to ask about the retcode of get_data in module_adapter: https://github.com/thesofproject/sof/blob/main/src/audio/module_adapter/module_adapter_ipc4.c#L162

I wonder if module_adapter should return non-zero error code when interface->get_configuration does not support?
In the present design it returns 0 while not supported, leading to the consequence that the host side will consider get_data successful, but the data obtained is unpredictable.

[lyakh]

Hi @lyakh, at the same time I would like to ask about the retcode of get_data in module_adapter: https://github.com/thesofproject/sof/blob/main/src/audio/module_adapter/module_adapter_ipc4.c#L162

I wonder if module_adapter should return non-zero error code when interface->get_configuration does not support? In the present design it returns 0 while not supported, leading to the consequence that the host side will consider get_data successful, but the data obtained is unpredictable.

@johnylin76 that's a good point! All the more that calling ops.get_large_config() in handler.c anyway returns the same error whether the method is absent or it failed

sof/src/ipc/ipc4/handler.c

Line 983 in 2cfc85e

ret = IPC4_MOD_INVALID_ID;

Could you submit a fix?

[johnylin76]

LGTM, thanks

[johnylin76]

Hi @lyakh, at the same time I would like to ask about the retcode of get_data in module_adapter: https://github.com/thesofproject/sof/blob/main/src/audio/module_adapter/module_adapter_ipc4.c#L162
I wonder if module_adapter should return non-zero error code when interface->get_configuration does not support? In the present design it returns 0 while not supported, leading to the consequence that the host side will consider get_data successful, but the data obtained is unpredictable.

@johnylin76 that's a good point! All the more that calling ops.get_large_config() in handler.c anyway returns the same error whether the method is absent or it failed

sof/src/ipc/ipc4/handler.c

Line 983 in 2cfc85e

ret = IPC4_MOD_INVALID_ID;

Could you submit a fix?

Thanks. I will provide that in the other PR afterwards.