Skip to content

refactor(abort): common gitdir#1244

Merged
spacewander merged 2 commits intotj:mainfrom
Rudxain:refactor-abort
Apr 14, 2026
Merged

refactor(abort): common gitdir#1244
spacewander merged 2 commits intotj:mainfrom
Rudxain:refactor-abort

Conversation

@Rudxain
Copy link
Copy Markdown
Contributor

@Rudxain Rudxain commented Apr 11, 2026 •
edited
Loading

This promotes gitdir to a global (shared within script) readonly, to:

  • improve perf
  • dedupe ("DRY")
  • ensure consistent value by avoiding data-races

@Rudxain Rudxain changed the title refactor(abort): common gitdir refactor(abort): common gitdir Apr 11, 2026
hyperupcall
hyperupcall requested changes Apr 11, 2026
View reviewed changes
@hyperupcall
Copy link
Copy Markdown
Collaborator

hyperupcall commented Apr 11, 2026

Thanks, just one request before I accept it.

@hyperupcall hyperupcall self-requested a review April 12, 2026 05:39
hyperupcall
hyperupcall approved these changes Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hyperupcall hyperupcall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@spacewander spacewander merged commit 8d1c970 into tj:main Apr 14, 2026
6 checks passed
@spacewander
Copy link
Copy Markdown
Collaborator

spacewander commented Apr 14, 2026

@Rudxain
Merged. Thank you!

@Rudxain Rudxain deleted the refactor-abort branch April 14, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

@hyperupcall hyperupcall hyperupcall approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rudxain @hyperupcall @spacewander