perf: improve Bytes::copy_to_bytes#688
Merged
Darksonn merged 1 commit intotokio-rs:masterfrom Apr 10, 2024
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
cd1401c to
a1849ab
Compare
Contributor
Author
|
cc @Darksonn |
braddunbar
approved these changes
Apr 10, 2024
Contributor
braddunbar
left a comment
There was a problem hiding this comment.
Nice! Great consolidation.
Contributor
Author
|
@braddunbar shall we merge this patch? Or it's still wait for further reviews? |
Contributor
Author
|
Thank you! |
Member
|
Thank you for the PR :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref - https://greptime.com/blogs/2024-04-09-rust-protobuf-performance#step-5-why-is-bytes-slice-so-slow
We already use this tech for
BytesMut, but not bring it forBytes. Namely, reduce the overhead of slice.