Skip to content

Remove incorrect guarantee for chunks_vectored#754

Merged
Darksonn merged 1 commit intomasterfrom
alice/fix-701
Jan 10, 2025
Merged

Remove incorrect guarantee for chunks_vectored#754
Darksonn merged 1 commit intomasterfrom
alice/fix-701

Conversation

@Darksonn
Copy link
Copy Markdown
Member

Fixes: #701
Fixes: #474

@Darksonn Darksonn requested a review from seanmonstar January 10, 2025 13:52
@Darksonn Darksonn merged commit 103d7bf into master Jan 10, 2025
@Darksonn Darksonn deleted the alice/fix-701 branch January 10, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buf::chunks_vectored() is wrong if chunk() isn't the whole buf Take::chunks_vectored breaks the API contract of providing all slices

2 participants