Skip to content
This repository was archived by the owner on Nov 30, 2018. It is now read-only.

Remove EMBER_CLI_FASTBOOT environment variable and not include fastbo…#20

Merged
tomdale merged 2 commits intotomdale:masterfrom
tsubomii:prepare-fastboot-1.0
Jun 7, 2017
Merged

Remove EMBER_CLI_FASTBOOT environment variable and not include fastbo…#20
tomdale merged 2 commits intotomdale:masterfrom
tsubomii:prepare-fastboot-1.0

Conversation

@tsubomii
Copy link
Copy Markdown
Collaborator

This change makes ember-network work with ember-cli-fastboot 1.0. It's backwards compatible. Works with ember-cli-fastboot that generates double build and without render using fastboot.

@kratiahuja
Copy link
Copy Markdown

I think ember-network has no fastboot tests. It would be nice to have some tests in here to make sure it works in CI too.

Copy link
Copy Markdown
Contributor

@kellyselden kellyselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version issue

package.json Outdated
{
"name": "ember-network",
"version": "0.3.1",
"version": "0.3.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump should be independent of this PR

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellyselden is right, would you mind removing this from the PR? We will bump the version in the package.json when we publish to npm.

@kellyselden
Copy link
Copy Markdown
Contributor

I got BroccoliMergeTrees: Expected Broccoli node, got undefined for inputNodes[0] when trying this branch out.

@kratiahuja
Copy link
Copy Markdown

@kellyselden these changes are same as ember-fetch which worked for me. Did you try it in a dummy app?

@tsubomii
Copy link
Copy Markdown
Collaborator Author

tsubomii commented Jun 6, 2017

@kellyselden I tried your app. The build works after I upgrade to ember-cli 2.14.0-beta.2, that’s the compatible version with ember-cli-fastboot 1.0 .

@tomdale
Copy link
Copy Markdown
Owner

tomdale commented Jun 7, 2017

Thanks @tsubomii!

@tomdale tomdale merged commit 03c0d10 into tomdale:master Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants