fix: upgrade http to https in session URL for non-local hosts#234
Merged
fix: upgrade http to https in session URL for non-local hosts#234
Conversation
When logging in with an http:// URL against a remote server, reqwest silently downgrades POST to GET on 301/302 redirects (per RFC 7231), causing subsequent commands like `tower teams switch` to fail with 404.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
konstantinoscs
approved these changes
Apr 2, 2026
Contributor
konstantinoscs
left a comment
konstantinoscs
left a comment
There was a problem hiding this comment.
if you tested it and it works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When logging in with an http:// tower URL against a remote server, subsequent POST requests (like session refresh) get silently downgraded to GET on 301/302 redirects per RFC 7231, causing 404s. This upgrades http to https at login time for non-localhost URLs.