Skip to content

Add zizmor security linter to pre-commit configuration#17

Closed
tsvikas wants to merge 1 commit intomainfrom
claude/add-zizmor-precommit-wAYc0
Closed

Add zizmor security linter to pre-commit configuration#17
tsvikas wants to merge 1 commit intomainfrom
claude/add-zizmor-precommit-wAYc0

Conversation

@tsvikas
Copy link
Copy Markdown
Owner

@tsvikas tsvikas commented Apr 8, 2026

Summary

This PR adds zizmor, a security linter for GitHub Actions workflows, to the pre-commit configuration.

Changes

  • Added zizmor pre-commit hook (v1.23.1) to .pre-commit-config.yaml
  • Added zizmor pre-commit hook configuration to the project template .pre-commit-config.yaml.jinja

Details

Zizmor is a security-focused linter for GitHub Actions workflows that helps identify potential security issues and misconfigurations. The hook is configured to run on all commits and will be automatically updated along with other dependencies during dependency updates.

https://claude.ai/code/session_011EyCivxz6Z1UJVsienHLQe

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider explicitly configuring the zizmor hook to limit its scope to your GitHub Actions workflow paths (e.g., .github/workflows) if you have vendored or non-standard YAML files that shouldn’t be linted, to avoid false positives and unnecessary runtime.
  • Ensure the ordering and positioning of the zizmor hook relative to actionlint in both the root and template pre-commit configs is intentional, since changing the sequence can affect how quickly CI feedback is surfaced for workflow issues.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider explicitly configuring the zizmor hook to limit its scope to your GitHub Actions workflow paths (e.g., `.github/workflows`) if you have vendored or non-standard YAML files that shouldn’t be linted, to avoid false positives and unnecessary runtime.
- Ensure the ordering and positioning of the zizmor hook relative to `actionlint` in both the root and template pre-commit configs is intentional, since changing the sequence can affect how quickly CI feedback is surfaced for workflow issues.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tsvikas tsvikas closed this Apr 8, 2026
@tsvikas tsvikas deleted the claude/add-zizmor-precommit-wAYc0 branch April 27, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants