Add zizmor security linter to pre-commit configuration#17
Closed
Add zizmor security linter to pre-commit configuration#17
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider explicitly configuring the zizmor hook to limit its scope to your GitHub Actions workflow paths (e.g.,
.github/workflows) if you have vendored or non-standard YAML files that shouldn’t be linted, to avoid false positives and unnecessary runtime. - Ensure the ordering and positioning of the zizmor hook relative to
actionlintin both the root and template pre-commit configs is intentional, since changing the sequence can affect how quickly CI feedback is surfaced for workflow issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider explicitly configuring the zizmor hook to limit its scope to your GitHub Actions workflow paths (e.g., `.github/workflows`) if you have vendored or non-standard YAML files that shouldn’t be linted, to avoid false positives and unnecessary runtime.
- Ensure the ordering and positioning of the zizmor hook relative to `actionlint` in both the root and template pre-commit configs is intentional, since changing the sequence can affect how quickly CI feedback is surfaced for workflow issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds zizmor, a security linter for GitHub Actions workflows, to the pre-commit configuration.
Changes
.pre-commit-config.yaml.pre-commit-config.yaml.jinjaDetails
Zizmor is a security-focused linter for GitHub Actions workflows that helps identify potential security issues and misconfigurations. The hook is configured to run on all commits and will be automatically updated along with other dependencies during dependency updates.
https://claude.ai/code/session_011EyCivxz6Z1UJVsienHLQe