chore: bump rubocop to ~> 1.86 and rubocop-rspec to ~> 3.9#58
chore: bump rubocop to ~> 1.86 and rubocop-rspec to ~> 3.9#58jasonbosco merged 1 commit intotypesense:masterfrom
Conversation
Bumps the linting toolchain: - rubocop: 1.72.2 (pinned exact) -> ~> 1.86 - rubocop-rspec: ~> 3.6 -> ~> 3.9 Loosens rubocop to a pessimistic constraint so it can pick up patch and minor bumps without another Gemfile change. The newer rubocop / rubocop-rspec set surfaces ten new offences. Nine of them are two cops misfiring on `spec/spec_helper.rb`, which is integration infrastructure (boots Typesense via docker-compose) rather than an example file: - `RSpec/Output` flags the `puts`/`print` calls that report docker-compose startup progress to the operator. They are not assertions on stdout, so the cop's intent does not apply. - `Naming/PredicateMethod` flags `ensure_typesense_running`, which returns a boolean but has heavy side effects (boots a docker container); renaming it to `ensure_typesense_running?` would be misleading. Both cops are excluded only for `spec/spec_helper.rb`. The tenth offence was a real but trivial `Style/HashAsLastArrayItem` / `Layout/SpaceInsideHashLiteralBraces` in `collection_spec.rb`, fixed by autocorrect. Verified: `bundle exec rubocop` reports 97 files, 0 offences. Full RSpec suite is unchanged at 151 / 1 / 27 (the single pre-existing `truncate_len` integration failure on master remains, unrelated).
|
Hey @erimicel , Thank you for the contributions! The PR description seems AI-generated and while I too used to let it write those PR descriptions for myself, the wall-of-text PR descriptions tend to be harder to read. Not to discourage use of AI tools of course, but toning the description a bit will be easier for us to understand what each PR does. |
Thanks for the feedback and for reviewing all the PRs I’ve created! That’s fair, I’ll trim down the descriptions. |
3 participants
Summary
Changes
Verification
Notes
Happy to refactor spec_helper.rb instead of ignoring cops if preferred.
PR Checklist