Remove validation index page#2909
Conversation
274596f to
c615c76
Compare
c615c76 to
8f1a764
Compare
8f1a764 to
36534af
Compare
36534af to
4333997
Compare
a97c681 to
d0faaad
Compare
| resource :environment_impact_assessment, only: %i[new create edit show update] | ||
|
|
||
| resource :reporting_type, only: %i[show edit update] | ||
| get "/tasks", to: "base#show" |
There was a problem hiding this comment.
I've left this in place to account for leftover references to it, but it might be overkill. (I'd make it a redirect, but the action it points at is already a redirect.)
d0faaad to
a2a4c45
Compare
benbaumann95
left a comment
There was a problem hiding this comment.
This might be intentional but worth just sense checking (I'm lacking a bit of context):
Think these actions still call the old route helpers.
app/controllers/planning_applications_controller.rb#L118
planning_application_validation_sitemap_path.
This is in the redirect_update_url or boundary geojson validation logic.
_validation_request_show_actions.html.erb:15
planning_application_validation_fee_items_path. This shared partial renders a "Continue" button for closed/active fee validation requests.
ownership_certificate_validation_requests/_show.html.erb:75
edit_planning_application_validation_ownership_certificate_path.
This renders a link saying "If this is incorrect, create another ownership certificate validation request". Viewing any ownership certificate validation request will break.
red_line_boundary_change_validation_requests/_applicant_rejected_response.html.erb:24
planning_application_validation_sitemap_path.
This is the "Continue" button shown when an applicant rejects a red line boundary change.
document/redactions/_form.html.erb:3
planning_application_validation_documents_redactions_path
submitting the redaction form will POST to a URL that doesn't exist (404).
f02ee93 to
2841f98
Compare
2841f98 to
9e5946d
Compare
If only the slug is needed (e.g., for the `task_path` helper) then that can be used as a string, not a Task object
b0c5a8a to
c64f82b
Compare
…page Revert "Merge pull request #2909 from unboxed/remove-validation-index-page"
Description of change
Now that all application types use the tasks model and sidebar, we don't ever need to show the old validation index page. Instead, redirect to the first available task, and remove all the leftover views.
Story Link
https://trello.com/c/OTZ31KzH/1769-validation-sidebar-for-all-applications-starts-with-first-task-hide-old-tasklist-view