Skip to content

Remove validation index page#2909

Merged
benjamineskola merged 8 commits intomainfrom
remove-validation-index-page
Feb 26, 2026
Merged

Remove validation index page#2909
benjamineskola merged 8 commits intomainfrom
remove-validation-index-page

Conversation

@benjamineskola
Copy link
Copy Markdown
Contributor

Description of change

Now that all application types use the tasks model and sidebar, we don't ever need to show the old validation index page. Instead, redirect to the first available task, and remove all the leftover views.

Story Link

https://trello.com/c/OTZ31KzH/1769-validation-sidebar-for-all-applications-starts-with-first-task-hide-old-tasklist-view

@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch 24 times, most recently from 274596f to c615c76 Compare February 24, 2026 17:12
@benjamineskola benjamineskola marked this pull request as ready for review February 24, 2026 17:12
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from c615c76 to 8f1a764 Compare February 25, 2026 09:43
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from 8f1a764 to 36534af Compare February 25, 2026 10:13
Comment thread app/controllers/planning_applications/validation/description_changes_controller.rb Dismissed
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from 36534af to 4333997 Compare February 25, 2026 10:21
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch 2 times, most recently from a97c681 to d0faaad Compare February 25, 2026 10:37
Comment thread config/routes/bops.rb
resource :environment_impact_assessment, only: %i[new create edit show update]

resource :reporting_type, only: %i[show edit update]
get "/tasks", to: "base#show"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left this in place to account for leftover references to it, but it might be overkill. (I'd make it a redirect, but the action it points at is already a redirect.)

@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from d0faaad to a2a4c45 Compare February 25, 2026 11:01
Copy link
Copy Markdown
Member

@benbaumann95 benbaumann95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be intentional but worth just sense checking (I'm lacking a bit of context):

Think these actions still call the old route helpers.

app/controllers/planning_applications_controller.rb#L118
planning_application_validation_sitemap_path.
This is in the redirect_update_url or boundary geojson validation logic.

_validation_request_show_actions.html.erb:15
planning_application_validation_fee_items_path. This shared partial renders a "Continue" button for closed/active fee validation requests.

ownership_certificate_validation_requests/_show.html.erb:75
edit_planning_application_validation_ownership_certificate_path.
This renders a link saying "If this is incorrect, create another ownership certificate validation request". Viewing any ownership certificate validation request will break.

red_line_boundary_change_validation_requests/_applicant_rejected_response.html.erb:24
planning_application_validation_sitemap_path.
This is the "Continue" button shown when an applicant rejects a red line boundary change.

document/redactions/_form.html.erb:3
planning_application_validation_documents_redactions_path
submitting the redaction form will POST to a URL that doesn't exist (404).

Comment thread app/controllers/planning_applications/validation/tasks_controller.rb Outdated
Comment thread app/controllers/planning_applications/validation/tasks_controller.rb Outdated
Comment thread app/controllers/planning_applications/validation/base_controller.rb Outdated
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch 3 times, most recently from f02ee93 to 2841f98 Compare February 25, 2026 15:12
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from 2841f98 to 9e5946d Compare February 25, 2026 15:13
If only the slug is needed (e.g., for the `task_path` helper) then
that can be used as a string, not a Task object
@benjamineskola benjamineskola force-pushed the remove-validation-index-page branch from b0c5a8a to c64f82b Compare February 25, 2026 15:19
@benjamineskola benjamineskola merged commit 24098e7 into main Feb 26, 2026
83 of 84 checks passed
@benjamineskola benjamineskola deleted the remove-validation-index-page branch February 26, 2026 11:12
pixeltrix added a commit that referenced this pull request Feb 27, 2026
…-page"

This reverts commit 24098e7, reversing
changes made to c09e7c0.
pixeltrix added a commit that referenced this pull request Feb 27, 2026
…page

Revert "Merge pull request #2909 from unboxed/remove-validation-index-page"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants