Skip to content

Remove UserFrosting-specific merge logic #802

@Silic0nS0ldier

Description

@Silic0nS0ldier

Configuration merging is a bespoke feature that was only added here to simply maintenance of UserFrosting's Sprinkle plugin system. The system operates on a few rules;

  1. replace where new incoming bundles replace those already defined.
  2. merge where 2 bundles are combined. styles and scripts arrays are merged manually via Set, everything else is left up to the jest-extend library.
  3. ignore where new incoming bundles are discarded if they collide.
  4. error where collisions trigger a failure.

The chosen rule is defined by the incoming bundle, defaulting to replace.

This is a lot of logic to maintain, and the primary consumers (UserFrosting developers) would expect that bundling logic is tied to their version of UserFrosting (it is, compatibility is managed via semver).

This style of asset management is very much on the way out but is likely to see continued use in niche scenarios. Keeping the cost of ownership low (minimum API surface, lockdown the feature set, but keep what is offered flexible) is the goal looking forward.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions