test: fix scriptParsed event expectations#61
Merged
hashseed merged 1 commit intov8:vee-eight-lkgrfrom Apr 17, 2018
RReverser:remove-incorrect-scriptparsed-expectations
Merged
test: fix scriptParsed event expectations#61hashseed merged 1 commit intov8:vee-eight-lkgrfrom RReverser:remove-incorrect-scriptparsed-expectations
hashseed merged 1 commit intov8:vee-eight-lkgrfrom
RReverser:remove-incorrect-scriptparsed-expectations
Conversation
As per Node.js docs, vm.Script instance is not bound to any context. However, this test was expecting otherwise and depended on implementation details which are going to change. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1013581
hashseed
approved these changes
Apr 17, 2018
hashseed
pushed a commit
that referenced
this pull request
Apr 18, 2018
Remove unused leftover from #61
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Remove unused leftover from v8#61
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Node.js docs,
vm.Scriptinstance is not bound to any context.However, this test was expecting otherwise and depended on implementation details which are going to change in https://chromium-review.googlesource.com/c/v8/v8/+/1013581.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes