fix(vitest): fix file snapshots in skipped suites considered obsolete#4795
Merged
sheremet-va merged 5 commits intovitest-dev:mainfrom Dec 28, 2023
Merged
fix(vitest): fix file snapshots in skipped suites considered obsolete#4795sheremet-va merged 5 commits intovitest-dev:mainfrom
sheremet-va merged 5 commits intovitest-dev:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2442
Supersedes and closes #4009
Current behavior was quite tricky, so I created (hopefully) cleaner repro here (and this is the base of the test I added in this PR):
The repro shows that treating snapshots as "obsolete" is not only about wrong warning, but also it has a consequence of deleting those skipped snapshots when running with
-u.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.