Skip to content

Adjust "non-existent" URLs in tests#18

Open
khitrenovich wants to merge 1 commit intovoid666:masterfrom
khitrenovich:adjust-test-urls
Open

Adjust "non-existent" URLs in tests#18
khitrenovich wants to merge 1 commit intovoid666:masterfrom
khitrenovich:adjust-test-urls

Conversation

@khitrenovich
Copy link
Copy Markdown

Looks like somebody registered "adadadadad.com", which causes unit tests to fail.

Ideally, packages like nock should be used in such cases, but this works as a quick fix.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 51

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.3%) to 98.81%

Totals Coverage Status
Change from base Build 47: 8.3%
Covered Lines: 54
Relevant Lines: 54

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants